|
Post by knapman [FD] on Jul 9, 2015 10:06:47 GMT
Updated Sysex phrase ID's to reflect EOF additions after discussions with Raynebc. Extended Guitar Notation. Simultaneous Cymbal + TOM hits for Real Drums. My my... somebody's been busy. Theme makers are going to have a field day with the new Extended Guitar Notation. I wonder if this means we'll get the option of horizontal highways a-la BandFuse... Is there any possibility of these Cymbal + Tom hits making their way to Advanced Drums? NOPE. NVM. Just reviewed the MIDI standard in my head and that just wouldn't fly too well with 4/5 lane drums. I'm looking forward to it nonetheless. Its really just a hardware issue, the instrument modes are all built around the physical limitations of the hardware itself, advanced drums at a base level maintains hardware compatibility with the rb pro grade of drum controllers and in this case the rb drums physically can't support this feature.
|
|
|
Post by raynebc on Jul 20, 2015 23:33:07 GMT
The new EOF hotfix has the cymbal+tom notation if anybody is interested in playing around with it. I don't know yet when support for it will be in Phase Shift.
|
|
|
Post by weirdpeople on Jan 1, 2016 3:31:31 GMT
I'd just thought i would come here to mention that I have started to implement some of this stuff in FoFiX.
One issue I came across some of the song.ini's that have come out of the C3 Phase Shift Converter have c-style comments at the bottom. Which blow up python's ini ConfigParser class (I had to do a bit of pre-processing to strip them out). FYI it only supports ';' and '#' to declare a comment.
The SysEx crash issues have been properly solved and we should be able to use SysEx events now (unlike the first attempt at fixing this).
I have recently finished(today) adding support for the extra audio tracks. For simplicity's sake I don't discriminate on multiple audio tracks for an instrument, so they will work for any instrument. The non-numbered versions of split instrument tracks are skipped when numbered ones exist. So anything that follows the '*word*_*#*.ogg' or '*word*.ogg' formats will be loaded(still one or the other if they have the same base name). Also 'preview.ogg' is obviously ignored for in-game play.
Also at this point for drums and other instruments it just treats the extra tracks like it would a single track for any single instrument. So i haven't implemented any mapping of tracks specific drum lanes yet. This will have to wait until i finish cleaning up the hit detection and related code.
Next i'm thinking about implementing some of the new ini options that have been introduced, what are the most used ones so far? I'll try to start with those.
Just as a side note, I've been trying to start cleaning through some of the worst parts of the code. (The stuff that's mainly blocking me from adding new features) So hopefully the two games start to have closer feature parity. I'm also hoping to release another FoFiX alpha release sometime in the first half of 2016 but we will have to see about that.
|
|
|
Post by TrojanNemo on Jan 1, 2016 4:29:43 GMT
One issue I came across some of the song.ini's that have come out of the C3 Phase Shift Converter have c-style comments at the bottom. Which blow up python's ini ConfigParser class (I had to do a bit of pre-processing to strip them out). FYI it only supports ';' and '#' to declare a comment. Oops, that was my doing. My only exposure has been with Phase Shift and even then only in creating and testing that tool since I play Rock Band myself. Next update I will change how those comments are added. What would be a safe way for comments that would work for both games? Unfortunately that would only be helpful going forward as I don't expect people would go back to edit existing songs just for that.
|
|
|
Post by weirdpeople on Jan 1, 2016 4:41:36 GMT
One issue I came across some of the song.ini's that have come out of the C3 Phase Shift Converter have c-style comments at the bottom. Which blow up python's ini ConfigParser class (I had to do a bit of pre-processing to strip them out). FYI it only supports ';' and '#' to declare a comment. Oops, that was my doing. My only exposure has been with Phase Shift and even then only in creating and testing that tool since I play Rock Band myself. Next update I will change how those comments are added. What would be a safe way for comments that would work for both games? Unfortunately that would only be helpful going forward as I don't expect people would go back to edit existing songs just for that. Well here is the relevant information from the python documentation. It looks like the ';' for comments was the original way of doing it according to wikipedia.
|
|
|
Post by TrojanNemo on Jan 1, 2016 4:44:48 GMT
That's also how I comment out lines in Rock Band DTAs. I assume that will work as well for Phase Shift?
|
|
|
Post by weirdpeople on Jan 1, 2016 4:50:18 GMT
Well i can certainly test it and see what happens.
|
|
|
Post by weirdpeople on Jan 1, 2016 5:08:29 GMT
So after testing i'm not sure if it actually supports any comment format at all, because any of the comment types put before the [song] section header causes the song to show up as "song.ini error in game". If comments were supported this wouldn't happen.
So if any garbage data is thrown into the ini file after the song section header phase shift reads it just fine.... so for example this is what i threw in an ini file...
[song] # Test = ;Test = // Test = asjdhga128397192shjdhas^&^@#%^Q@ #QW&*#^$*&Q@#$)Q*@#$)(JKHDAKSHD album = The Raven That Refused to Sing (and Other Stories) *snip*
|
|