|
Post by Alternity on May 3, 2016 1:24:12 GMT
I'm currently working on a song.ini editor/creator. So far I've only worked on the GUI and the load handling, I'm wondering if I forgot some crucial settings, would like your help to pinpoint those things, if I'm missing any. I'm a very noob programmer, this is done in Python 2.7.x.
|
|
|
Post by Ačāla on May 3, 2016 3:11:53 GMT
One thing I'm noticing is the non-word "halp." Should be "help."
On a much less "beta" note, you could add in presets. Take for example, automated tuning. "Dropped D\C\B" for one.
But to answer your question, looks absolutely fine.
|
|
|
Post by Alternity on May 3, 2016 3:41:12 GMT
Well, the "HALP" button was a joke, if you'd read MEMEs from time to time you'd get it You're right though, I haven't thought about presets for tunings, good thing to look for, thanks.
|
|
|
Post by Ačāla on May 3, 2016 4:10:36 GMT
If you do end up doing presets, add logic to make sure people don't overwrite old or preexisting files or entries.
I can send you a whole list of standards and presets, if you like.
|
|
|
Post by djlastnight on May 3, 2016 9:34:51 GMT
Looks nice!
|
|
|
Post by amyrakunejo on Jul 9, 2016 10:10:23 GMT
I would add custom logic for things like 'icon = gdrb', and other things like Sysex Controls, etc.
Other than that, making sure that it is compatible with XP/Vista/7/etc, as well as x86 and WOW64 is a must. I don't know how much of an issue this would be with Python, but it is always good to ensure compatibility for all users (because compatibility patches can be quite a hassle later).
From the screenshot though, it looks clean and well organized. Great work, mon ami.
|
|
|
Post by raynebc on Jul 9, 2016 19:40:34 GMT
The most important thing I see missing is the MIDI delay value. Also, the option to support custom INI tags couldn't hurt, in case some FoF mods or PS themes are able to make use of certain tags.
Some missing FoF related stuff includes lyrics (boolean), eighthnote_hopo (boolean), loading_phrase (string) and frets (string, name of chart author).
Some missing PS related stuff includes multiplier_note (number, EOF always writes this as 116, but it's possible another person may end up using a different MIDI note to mark star power), pro_drums (boolean, defined as "True" if tom notation is present and the default green/blue/yellow drum note type is cymbal).
Lastly, it may not be widely used, but the 22 fret pro guitar/bass tracks are allowed to have a unique tuning, in case the author ends up putting something entirely different in those tracks.
|
|
|
Post by amyrakunejo on Jul 12, 2016 16:44:12 GMT
The most important thing I see missing is the MIDI delay value. Also, the option to support custom INI tags couldn't hurt, in case some FoF mods or PS themes are able to make use of certain tags. Some missing FoF related stuff includes lyrics (boolean), eighthnote_hopo (boolean), loading_phrase (string) and frets (string, name of chart author). Some missing PS related stuff includes multiplier_note (number, EOF always writes this as 116, but it's possible another person may end up using a different MIDI note to mark star power), pro_drums (boolean, defined as "True" if tom notation is present and the default green/blue/yellow drum note type is cymbal). Lastly, it may not be widely used, but the 22 fret pro guitar/bass tracks are allowed to have a unique tuning, in case the author ends up putting something entirely different in those tracks. Actually, I had always wondered about what that multiplier_note = 116 had meant. So, that is a key binding method, then?
|
|
|
Post by raynebc on Jul 12, 2016 17:32:41 GMT
It defines which note the MIDI file itself uses as the star power marker.
|
|
|
Post by JarheadHME on Jul 12, 2016 18:52:53 GMT
Something else that could be worth adding is the "banner_link" and "link_name" tags. They allow you to link to certain URLs in the loading screen. The actual tags are
banner_link_a = <First URL> link_name_a = <Text to appear for first URL> banner_link_b = <Second URL> link_name_b = <Text to appear for second URL>
|
|