Drum note lengths revert to 1 after saving

[Sygenysis]

As of late, as in, just today it's started happening. Whenever I modify the note lengths for drums (no other instruments have this issue) upon saving the .mid, the changes revert back, and the notes all have the minimum length of 1.

This has only just now come up, and I'm pretty confident I didn't change any settings. This was on R1337, I believe, but I upgraded to the latest hotfix, and the same thing still happens. It's happened to 2 the last 2 charts I've done, so far.

Thanks in advance for any assistance.

[raynebc]

Please confirm if the project file shows the notes being shortened, or if the notes are only shortened in-game (ie. in the MIDI). It would be expected behavior for the notes to be shortened when exporting to MIDI because rhythm games have no use for drum notes having a sustain unless the notes in question are markers used for big rock endings or drum fills.

If the notes are being shortened to 1ms and shown this way inside of EOF, please send me the project file so I can check it out.

[Sygenysis]

Even though it shouldn't really matter, in the sense of charting for FoF/PS, my friend needs to import the files into Reaper/the C3 Tools MIDI Cleaner, where the note lengths have to be anything above 1.

And yes, the notes are only being shortened in the MIDI, they look fine when importing the EoF project file.

This is a really new thing that's happening. I've always saved the MIDI and the note lengths have worked out. I didn't update EoF in-between starting songs, so it is indeed a new behavior, but not because of a hotfix or anything.

[raynebc]

EOF has exported drum notes as being truncated for ages. Looking back in Subversion, it looks like it was capped at 1ms since 2010 and that changed to 1 delta tick within a couple years. In fact I originally made this change because it was necessary to prevent FoF/FoFiX from malfunctioning on drum charts (https://code.google.com/p/editor-on-fire/issues/detail?id=162).

I could have sworn one of the recent C3 tools had a feature to extend the length of notes that were only 1 delta tick long, but I can't find anything confirming that. It may be worth asking about it on the C3 forum in case their tools may have changed regarding this condition lately.

[Sygenysis]

That's a feature that was put in the MIDI cleaner pretty recently, yeah. The MIDI cleaner keeps returning an error when those MIDIs are imported.

I guess you might be right about the C3 tools creating the issue. We've stuck to a pretty standard, unchanging formula for charting songs in EoF, then importing to REAPER, etc., and we haven't changed anything we've done.

[raynebc]

If they won't change their tool, I can probably make a user preference for a higher drum note cap, but I'll need exact requirements from the C3 developers for how short the note can (ie. in delta ticks) be before their tool rejects it. If you can get that info from them I can add this change to EOF, but if that preference is in use I'll probably have to enable a warning during save if FoF/PS MIDI export is enabled saying that the drum chart may malfunction in some/all versions of Frets on Fire.

[Sygenysis]

In the tool, it explicitly says it fixes note lengths of 1, in EoF terms. Through having several hundred songs converted, any value over 1, as low as 2, I believe, in EoF note lengths, (I'm not sure the delta tick conversion, but it seems to round up, or just can't be 1) seems to work. Only 1s return the error.

Bizarrely enough, my friend tried rolled back C3 Tools versions, and the MIDI Cleaner worked normally. He also tried in the latest version, again, and it also worked. Whatever the issue was isn't happening anymore, on the end that matters.

[raynebc]

That is odd. If it happens again, the C3 folks may want to know about it.