tylerfg
Yorkshire Terrier
Posts: 75
|
Post by tylerfg on Sept 14, 2012 18:57:28 GMT
Ok, I'm finishing up my first custom (I won't post it though, due to guidelines.) and it works great in Phase Shift. But when I put album info and tiers in the notepad, (Yes, I did it under "song" and all that.) it automatically changes back to the original stuff. (Basically all the tiers and song and artist name, but no album info) The album artwork works fine, but this is giving me trouble. What am I doing wrong?
|
|
|
Post by raynebc on Sept 14, 2012 19:20:28 GMT
Assuming you use EOF, if you edit song.ini and then re-save your chart in EOF, your edits from notepad are overwritten. In EOF, if you use Song>INI Settings, you can enter them into the project and they will be written to song.ini during each save.
|
|
tylerfg
Yorkshire Terrier
Posts: 75
|
Post by tylerfg on Sept 14, 2012 20:13:22 GMT
Thanks, I think that worked.
|
|
|
Post by knapman [FD] on Sept 15, 2012 8:43:15 GMT
this problem actually comes up a lot, we regularly get song inis with lost data, the problem is its not obvious eof is going to just wipe files completely and replace it with older stored data, rather than just updating the specific lines it needs to, and its an easy problem to miss after its happened so often doesn't always get caught until its too late and backups may not even exist anymore
it would be nice if there was some handling or at least a warning so people couldn't easily do this accidentally, like if eof checks if the ini data has been changed since it imported so it could warn that manual edits could be lost or offer to reimport the data before save
|
|
|
Post by raynebc on Sept 15, 2012 17:24:31 GMT
I might be able to look into it, but that would be like editing the MIDI file with another editor and re-saving the project, expecting the MIDI not to be overwritten by EOF.
|
|
|
Post by asskickulater on Sept 15, 2012 17:48:36 GMT
perhaps you can add a setting so that eof just doesnt make a song.ini in general.
|
|
|
Post by raynebc on Sept 15, 2012 19:26:05 GMT
Then people would wonder why that file wasn't being created when they create new charts. Things get complicated when people avoid following the correct process.
|
|
|
Post by asskickulater on Sept 15, 2012 19:44:02 GMT
Then people would wonder why that file wasn't being created when they create new charts. Things get complicated when people avoid following the correct process. that's why I said setting, have it enabled by default, and give the option to have it turned off.. wouldn't be very useful to the noobs, but people who chart regularly it would benefit quite a bit, I don't even use the song.ini EOF creates.
|
|
|
Post by knapman [FD] on Sept 15, 2012 20:25:58 GMT
well it would be great to see something done to improve the current situation as we are seeing this a lot, if there is a more fitting solution to fit with a preferred process then great, i'd just be happy to see any improvements that stop this happening so often
edit: i think what ak says seems to be quite a common occurrence, i think a lot of people aren't realising why eof seems to be fighting them with the song inis and rather than looking into it they are just ignoring the ones eof generates and using their own ones, so even in the cases where we aren't seeing the problem people still aren't following the process eof is expecting so the problems going to happen the moment someone else attempts to save the project and doesn't realise the ini will be wrong
|
|
|
Post by raynebc on Sept 15, 2012 22:38:18 GMT
Here's a simple, partial solution I could easily implement: A preference where during save, write a song.ini file if it doesn't exist at the target location. Otherwise don't write it unless the author entered or removed an INI entry within EOF using Song>INI Settings dialog.
This isn't a complete fix though since people who don't know better still might edit their INI without enabling the setting, or people who enable the setting won't have certain tags created as they author new things (sysex presence tags, empty instrument track tags, etc).
If anybody has suggestions for improvements to the INI settings or song properties dialogs that would prevent the need to edit song.ini externally, let me know and I can consider them.
knapman's suggestion of partial alterations to the song.ini file is doable if it's considered the only good solution, but it would require EOF to decide which tags are OK to keep as is (any custom type tags that EOF doesn't recognize natively) and which ones must be mandatorily overwritten by EOF (ie. empty instrument track). Then there are ones where it becomes a gray matter. Does EOF replace the song.ini's artist tag with an artist tag that's defined in the project? Track/band difficulties?
|
|
|
Post by raynebc on Oct 6, 2012 6:47:19 GMT
I haven't heard back about this issue. At this point, I think it may be best to force EOF to re-import song.ini (if it is present) every time a project is loaded, and any tags in the INI that exist in the project already will replace those in the project. This is probably the best option I can come up with, let me know if you think it will be sufficient.
|
|
|
Post by asskickulater on Oct 6, 2012 9:11:30 GMT
why not just have eof not save a song.ini if one already exists? or have a dialogue asking if you want to overwrite it? though the importing seems fine to me
|
|
|
Post by knapman [FD] on Oct 6, 2012 15:00:45 GMT
yea refreshing the details on load sounds good
|
|
|
Post by raynebc on Oct 6, 2012 20:28:35 GMT
why not just have eof not save a song.ini if one already exists? The way people should be authoring is starting with the beat mapping, then after they've created and saved that, start authoring notes. If EOF didn't write a new song.ini after the first save (unless the user deleted song.ini), all of the INI tags that depend on the contents of the chart or are added by users (ie. in Song Properties) afterward would end up not going into the file. I'll work on re-importing the INI during each project load, since it's the only way to avoid missing anything the user added externally.
|
|
|
Post by raynebc on Oct 14, 2012 3:40:36 GMT
Now EOF will check song.ini when a project is loaded, and if any INI tags are new or altered compared to what's already in the project, it will prompt whether or not to merge the changes into the project. If allowed to merge, an undo state is made and the chart is indicated as altered after it is loaded up. I believe this addresses the concerns in this thread, if not, please let me know.
|
|