Post by raynebc on Sept 27, 2019 20:41:57 GMT
Working with somebody in a chart conversion discord, 5 lane drum chart (ie. Guitar Hero drum) handling for multiple charts was being troubleshot where all of the yellow, blue and green notes are toms. Initially, since there were no cymbals in these charts, EOF did not write a "pro_drums = True" INI tag and did not write tom markers for all of the notes, as it was expected this would be treated as a pre-RB3 era chart in which notes were considered toms by default. However the user indicated that the game displayed cymbal notes.
I added a preference in EOF to force this kind of chart to write with pro drum notation, so that even charts which had no cymbals would write with pro drum tom markers for every yellow, blue and green drum gem, and "pro_drums = True" is written to the chart's INI file. The user indicated that after this change, the game's advanced drums mode would now display the chart as all toms as expected. The normal drum mode would now display lane 6 toms as toms as expected, but some other toms (lanes 3 and 5) were still displayed as cymbals.
It's possible that these cymbal conversion problems extend to 4 lane drum charts instead of just 5 lane drum charts, but that's unclear.
I added a preference in EOF to force this kind of chart to write with pro drum notation, so that even charts which had no cymbals would write with pro drum tom markers for every yellow, blue and green drum gem, and "pro_drums = True" is written to the chart's INI file. The user indicated that after this change, the game's advanced drums mode would now display the chart as all toms as expected. The normal drum mode would now display lane 6 toms as toms as expected, but some other toms (lanes 3 and 5) were still displayed as cymbals.
It's possible that these cymbal conversion problems extend to 4 lane drum charts instead of just 5 lane drum charts, but that's unclear.